Dmitry Marakasov <[email protected]> writes: > * Max Brazhnikov ([email protected]) wrote: > >> > > Remove CMAKE_USE_PTHREAD. >> > > >> > > This has been in area51 since April, and discussions with makc >> > > indicate this was only needed when we supported FreeBSD < 7. >> > > >> > > Approved by: avilla (mentor), portmgr (tabthorpe) >> > > Feature safe: yes >> > > >> > > Revision Changes Path >> > > 1.13 +1 -15 ports/Mk/bsd.cmake.mk >> > >> > This has broken at least devel/bullet. This is not feature safe at all. >> >> Can you show the build log? > > http://people.freebsd.org/~amdmi3/bullet_default.log > > with LDFLAGS=-pthread it builds fine: > > http://people.freebsd.org/~amdmi3/bullet_ldflags.log > > Likely that's a correct way to fix it as bullet CMakeLists.txt > doesn't do any attempts to detect/use thread libs, however the > point is that cited commit is not safe and may touch more ports.
Well, we did run test builds before committing, so it should have been a safe commit. The commit touched all ports which used the removed setting, I don't see which others it may have touched. As for the build log: what system is that? Can you post a build log with CMAKE_VERBOSE=1 set? _______________________________________________ [email protected] mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "[email protected]"
