Update of
/var/cvs/contributions/CMSContainer_Modules/subsite/src/java/com/finalist/cmsc/subsite/forms
In directory
james.mmbase.org:/tmp/cvs-serv30319/subsite/src/java/com/finalist/cmsc/subsite/forms
Modified Files:
SubSiteAction.java
Log Message:
CMSC-907 Code Quality with PMD
Add final modifier to Util classes
Add final modifier to Logger instances
Change Boolean, Integer and Long instantiation to valueOf calls
See also:
http://cvs.mmbase.org/viewcvs/contributions/CMSContainer_Modules/subsite/src/java/com/finalist/cmsc/subsite/forms
See also: http://www.mmbase.org/jira/browse/CMSC-907
Index: SubSiteAction.java
===================================================================
RCS file:
/var/cvs/contributions/CMSContainer_Modules/subsite/src/java/com/finalist/cmsc/subsite/forms/SubSiteAction.java,v
retrieving revision 1.9
retrieving revision 1.10
diff -u -b -r1.9 -r1.10
--- SubSiteAction.java 10 May 2008 16:31:48 -0000 1.9
+++ SubSiteAction.java 16 May 2008 11:45:45 -0000 1.10
@@ -48,7 +48,7 @@
/**
* MMBase logging system
*/
- private static Logger log =
Logging.getLoggerInstance(SearchAction.class.getName());
+ private static final Logger log =
Logging.getLoggerInstance(SearchAction.class.getName());
@Override
public ActionForward execute(ActionMapping mapping, ActionForm form,
@@ -166,13 +166,13 @@
Field field =
query.getCloud().getNodeManager(destinationManager).getField("publishdate");
//Does this work?
StepField basicStepField = query.getStepField(field);
if(year != -1) {
- SearchUtil.addConstraint(query, new
BasicFieldValueDateConstraint(basicStepField, new Integer(year),
FieldValueDateConstraint.YEAR));
+ SearchUtil.addConstraint(query, new
BasicFieldValueDateConstraint(basicStepField, Integer.valueOf(year),
FieldValueDateConstraint.YEAR));
}
if(month != -1) {
- SearchUtil.addConstraint(query, new
BasicFieldValueDateConstraint(basicStepField, new Integer(month),
FieldValueDateConstraint.MONTH));
+ SearchUtil.addConstraint(query, new
BasicFieldValueDateConstraint(basicStepField, Integer.valueOf(month),
FieldValueDateConstraint.MONTH));
}
if(day != -1) {
- SearchUtil.addConstraint(query, new
BasicFieldValueDateConstraint(basicStepField, new Integer(day),
FieldValueDateConstraint.DAY_OF_MONTH));
+ SearchUtil.addConstraint(query, new
BasicFieldValueDateConstraint(basicStepField, Integer.valueOf(day),
FieldValueDateConstraint.DAY_OF_MONTH));
}
}
_______________________________________________
Cvs mailing list
[email protected]
http://lists.mmbase.org/mailman/listinfo/cvs
