Update of
/var/cvs/contributions/CMSContainer_Modules/rating/src/java/com/finalist/cmsc/rating/taglib
In directory
james.mmbase.org:/tmp/cvs-serv30319/rating/src/java/com/finalist/cmsc/rating/taglib
Modified Files:
GetTag.java
Log Message:
CMSC-907 Code Quality with PMD
Add final modifier to Util classes
Add final modifier to Logger instances
Change Boolean, Integer and Long instantiation to valueOf calls
See also:
http://cvs.mmbase.org/viewcvs/contributions/CMSContainer_Modules/rating/src/java/com/finalist/cmsc/rating/taglib
See also: http://www.mmbase.org/jira/browse/CMSC-907
Index: GetTag.java
===================================================================
RCS file:
/var/cvs/contributions/CMSContainer_Modules/rating/src/java/com/finalist/cmsc/rating/taglib/GetTag.java,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -b -r1.4 -r1.5
--- GetTag.java 12 Apr 2008 14:26:32 -0000 1.4
+++ GetTag.java 16 May 2008 11:45:45 -0000 1.5
@@ -18,12 +18,12 @@
Rating rating = RatingUtil.getContentRating(number);
getJspContext().setAttribute(var, new Float(rating.getRating()));
if (countVar != null) {
- getJspContext().setAttribute(countVar, new
Integer(rating.getCount()));
+ getJspContext().setAttribute(countVar,
Integer.valueOf(rating.getCount()));
}
if (userVar != null && user != null) {
int userRating = RatingUtil.getUserRating(number, user);
- getJspContext().setAttribute(userVar, new Integer(userRating));
+ getJspContext().setAttribute(userVar, Integer.valueOf(userRating));
}
}
_______________________________________________
Cvs mailing list
[email protected]
http://lists.mmbase.org/mailman/listinfo/cvs
