[MMBASE CVS] contributions/CMSContainer/cmsc/contentrepository/src/java/com/finalist/cmsc/resources/forms DeleteSecondaryContentAction.java SearchAction.java

[Nico Klasens]

Update of 
/var/cvs/contributions/CMSContainer/cmsc/contentrepository/src/java/com/finalist/cmsc/resources/forms
In directory 
james.mmbase.org:/tmp/cvs-serv30736/cmsc/contentrepository/src/java/com/finalist/cmsc/resources/forms

Modified Files:
        DeleteSecondaryContentAction.java SearchAction.java 
Log Message:
CMSC-907 Code Quality with PMD
Add final modifier to Util classes
Add final modifier to Logger instances
Change Boolean, Integer and Long instantiation to valueOf calls


See also: 
http://cvs.mmbase.org/viewcvs/contributions/CMSContainer/cmsc/contentrepository/src/java/com/finalist/cmsc/resources/forms
See also: http://www.mmbase.org/jira/browse/CMSC-907


Index: DeleteSecondaryContentAction.java
===================================================================
RCS file: 
/var/cvs/contributions/CMSContainer/cmsc/contentrepository/src/java/com/finalist/cmsc/resources/forms/DeleteSecondaryContentAction.java,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -b -r1.7 -r1.8
--- DeleteSecondaryContentAction.java   25 Feb 2008 14:45:21 -0000      1.7
+++ DeleteSecondaryContentAction.java   16 May 2008 11:46:31 -0000      1.8
@@ -3,9 +3,7 @@
 import javax.servlet.http.HttpServletRequest;
 import javax.servlet.http.HttpServletResponse;
 
-import org.apache.struts.action.ActionForm;
-import org.apache.struts.action.ActionForward;
-import org.apache.struts.action.ActionMapping;
+import org.apache.struts.action.*;
 import org.mmbase.bridge.*;
 import org.mmbase.util.logging.Logger;
 import org.mmbase.util.logging.Logging;
@@ -15,7 +13,7 @@
 
 public class DeleteSecondaryContentAction extends MMBaseAction {
 
-   private static transient Logger log = 
Logging.getLoggerInstance(DeleteSecondaryContentAction.class.getName());
+   private static final Logger log = 
Logging.getLoggerInstance(DeleteSecondaryContentAction.class.getName());
 
    private static final String ACTION_REMOVE = "remove";
    private static final String ACTION_CANCEL = "cancel";


Index: SearchAction.java
===================================================================
RCS file: 
/var/cvs/contributions/CMSContainer/cmsc/contentrepository/src/java/com/finalist/cmsc/resources/forms/SearchAction.java,v
retrieving revision 1.8
retrieving revision 1.9
diff -u -b -r1.8 -r1.9
--- SearchAction.java   10 May 2008 16:31:23 -0000      1.8
+++ SearchAction.java   16 May 2008 11:46:31 -0000      1.9
@@ -39,7 +39,7 @@
    /**
     * MMbase logging system
     */
-   private static Logger log = 
Logging.getLoggerInstance(SearchAction.class.getName());
+   private static final Logger log = 
Logging.getLoggerInstance(SearchAction.class.getName());
 
 
    @Override
@@ -86,14 +86,14 @@
       if (StringUtils.isNotEmpty(searchForm.getObjectid())) {
          Integer objectId = null;
          if (searchForm.getObjectid().matches("^\\d+$")) {
-            objectId = new Integer(searchForm.getObjectid());
+            objectId = Integer.valueOf(searchForm.getObjectid());
          }
          else {
             if (cloud.hasNode(searchForm.getObjectid())) {
-               objectId = new 
Integer(cloud.getNode(searchForm.getObjectid()).getNumber());
+               objectId = 
Integer.valueOf(cloud.getNode(searchForm.getObjectid()).getNumber());
             }
             else {
-               objectId = new Integer(-1);
+               objectId = Integer.valueOf(-1);
             }
          }
          SearchUtil.addEqualConstraint(query, nodeManager, NUMBER_FIELD, 
objectId);
_______________________________________________
Cvs mailing list
Cvs@lists.mmbase.org
http://lists.mmbase.org/mailman/listinfo/cvs