[MMBASE CVS] contributions/CMSContainer/cmsc/utilities/src/java/com/finalist/googlesitemap Generator.java FileSitemapModel.java

[Nico Klasens]

Update of 
/var/cvs/contributions/CMSContainer/cmsc/utilities/src/java/com/finalist/googlesitemap
In directory 
james.mmbase.org:/tmp/cvs-serv30736/cmsc/utilities/src/java/com/finalist/googlesitemap

Modified Files:
        Generator.java FileSitemapModel.java 
Log Message:
CMSC-907 Code Quality with PMD
Add final modifier to Util classes
Add final modifier to Logger instances
Change Boolean, Integer and Long instantiation to valueOf calls


See also: 
http://cvs.mmbase.org/viewcvs/contributions/CMSContainer/cmsc/utilities/src/java/com/finalist/googlesitemap
See also: http://www.mmbase.org/jira/browse/CMSC-907


Index: Generator.java
===================================================================
RCS file: 
/var/cvs/contributions/CMSContainer/cmsc/utilities/src/java/com/finalist/googlesitemap/Generator.java,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -b -r1.4 -r1.5
--- Generator.java      26 Nov 2007 11:43:41 -0000      1.4
+++ Generator.java      16 May 2008 11:46:31 -0000      1.5
@@ -24,7 +24,7 @@
 public class Generator {
 
    /** MMbase logging system */
-   private static Logger log = 
Logging.getLoggerInstance(Generator.class.getName());
+   private static final Logger log = 
Logging.getLoggerInstance(Generator.class.getName());
 
    private static final String CONFIGURATION_RESOURCE_NAME = 
"/com/finalist/googlesitemap/generator.properties";
 


Index: FileSitemapModel.java
===================================================================
RCS file: 
/var/cvs/contributions/CMSContainer/cmsc/utilities/src/java/com/finalist/googlesitemap/FileSitemapModel.java,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -b -r1.4 -r1.5
--- FileSitemapModel.java       26 Nov 2007 11:43:41 -0000      1.4
+++ FileSitemapModel.java       16 May 2008 11:46:31 -0000      1.5
@@ -26,7 +26,7 @@
 
    public Object getRoot() {
       if (startingDirectory == null) {
-         throw new NullPointerException();
+         throw new IllegalArgumentException("startingDirectory is null");
       }
       if (startingDirectory.length() == 0) {
          throw new IllegalArgumentException("startingDirectory may not be 
empty");
@@ -56,10 +56,11 @@
    public boolean isUrl(Object root) {
       if (root instanceof File) {
          File file = ((File) root);
-         if (!file.isDirectory())
+         if (!file.isDirectory()) {
             return file.getName().endsWith(".htm") || 
file.getName().endsWith(".html")
                   || file.getName().endsWith(".shtml");
       }
+      }
       return false;
    }
 
_______________________________________________
Cvs mailing list
Cvs@lists.mmbase.org
http://lists.mmbase.org/mailman/listinfo/cvs