Update of
/var/cvs/contributions/CMSContainer/cmsc/taglib/src/java/com/finalist/cmsc/taglib/portlet
In directory
james.mmbase.org:/tmp/cvs-serv30736/cmsc/taglib/src/java/com/finalist/cmsc/taglib/portlet
Modified Files:
BasicURLTag.java PortletTag.java IsAllowedEditTag.java
Log Message:
CMSC-907 Code Quality with PMD
Add final modifier to Util classes
Add final modifier to Logger instances
Change Boolean, Integer and Long instantiation to valueOf calls
See also:
http://cvs.mmbase.org/viewcvs/contributions/CMSContainer/cmsc/taglib/src/java/com/finalist/cmsc/taglib/portlet
See also: http://www.mmbase.org/jira/browse/CMSC-907
Index: BasicURLTag.java
===================================================================
RCS file:
/var/cvs/contributions/CMSContainer/cmsc/taglib/src/java/com/finalist/cmsc/taglib/portlet/BasicURLTag.java,v
retrieving revision 1.10
retrieving revision 1.11
diff -u -b -r1.10 -r1.11
--- BasicURLTag.java 10 May 2008 16:31:23 -0000 1.10
+++ BasicURLTag.java 16 May 2008 11:46:35 -0000 1.11
@@ -243,7 +243,7 @@
*/
public void setSecure(String secure) {
this.secure = secure;
- this.secureBoolean = new Boolean(secure);
+ this.secureBoolean = Boolean.valueOf(secure);
}
Index: PortletTag.java
===================================================================
RCS file:
/var/cvs/contributions/CMSContainer/cmsc/taglib/src/java/com/finalist/cmsc/taglib/portlet/PortletTag.java,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -b -r1.7 -r1.8
--- PortletTag.java 28 Jan 2008 21:15:45 -0000 1.7
+++ PortletTag.java 16 May 2008 11:46:35 -0000 1.8
@@ -178,7 +178,7 @@
modeType = "view";
isVisible = true;
}
- portletInfo.addPortletMode(mode, modeURL.toString(control, new
Boolean(request.isSecure())), mode
+ portletInfo.addPortletMode(mode, modeURL.toString(control,
Boolean.valueOf(request.isSecure())), mode
.equals(currentMode), isVisible, modeType);
}
}
@@ -193,7 +193,7 @@
WindowState currentState = control.getState(portletWindow);
control.setState(portletWindow, state);
- portletInfo.addPortletWindowState(state.toString().substring(0,
3), stateURL.toString(control, new Boolean(
+ portletInfo.addPortletWindowState(state.toString().substring(0,
3), stateURL.toString(control, Boolean.valueOf(
request.isSecure())), state.equals(currentState));
}
}
Index: IsAllowedEditTag.java
===================================================================
RCS file:
/var/cvs/contributions/CMSContainer/cmsc/taglib/src/java/com/finalist/cmsc/taglib/portlet/IsAllowedEditTag.java,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -b -r1.5 -r1.6
--- IsAllowedEditTag.java 26 Nov 2007 11:43:41 -0000 1.5
+++ IsAllowedEditTag.java 16 May 2008 11:46:35 -0000 1.6
@@ -16,7 +16,7 @@
@SuppressWarnings("serial")
public class IsAllowedEditTag extends TagSupport {
- private static Logger log =
Logging.getLoggerInstance(IsAllowedEditTag.class.getName());
+ private static final Logger log =
Logging.getLoggerInstance(IsAllowedEditTag.class.getName());
private int channelNumber;
private boolean inverse;
_______________________________________________
Cvs mailing list
[email protected]
http://lists.mmbase.org/mailman/listinfo/cvs
