Update of
/var/cvs/contributions/CMSContainer/cmsc/taglib/src/java/com/finalist/cmsc/taglib/editors
In directory
james.mmbase.org:/tmp/cvs-serv30736/cmsc/taglib/src/java/com/finalist/cmsc/taglib/editors
Modified Files:
DumpDefaultsTag.java
Log Message:
CMSC-907 Code Quality with PMD
Add final modifier to Util classes
Add final modifier to Logger instances
Change Boolean, Integer and Long instantiation to valueOf calls
See also:
http://cvs.mmbase.org/viewcvs/contributions/CMSContainer/cmsc/taglib/src/java/com/finalist/cmsc/taglib/editors
See also: http://www.mmbase.org/jira/browse/CMSC-907
Index: DumpDefaultsTag.java
===================================================================
RCS file:
/var/cvs/contributions/CMSContainer/cmsc/taglib/src/java/com/finalist/cmsc/taglib/editors/DumpDefaultsTag.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -b -r1.1 -r1.2
--- DumpDefaultsTag.java 17 Dec 2007 20:30:52 -0000 1.1
+++ DumpDefaultsTag.java 16 May 2008 11:46:36 -0000 1.2
@@ -76,8 +76,7 @@
public boolean meets(Node node) {
String fieldValue = node.getStringValue(field);
- switch (operator) {
- case OPERATOR_EQUALS:
+ if (operator == OPERATOR_EQUALS) {
return value.equals(fieldValue);
}
return false;
@@ -174,7 +173,7 @@
for (String key : backupMap.keySet()) {
HashSet<Node> values = backupMap.get(key);
- report.append(key).append(" ").append(values.size()).append(" nodes.
<br/>");
+ report.append(key).append(' ').append(values.size()).append(" nodes.
<br/>");
Calendar cal = Calendar.getInstance();
long htimestamp = cal.get(Calendar.YEAR) * 10000 +
(cal.get(Calendar.MONTH) + 1) * 100
_______________________________________________
Cvs mailing list
[email protected]
http://lists.mmbase.org/mailman/listinfo/cvs
