Volker Quetschke wrote: > Hi! > >> 1. grace >> >> date : 25 Nov 2002 >> version: 5.1.12-1 >> status : updated package available for review >> notes : http://www.cygwin.com/ml/cygwin-apps/2002-11/msg00322.html >> reviews: http://www.cygwin.com/ml/cygwin-apps/2003-03/msg00254.html >> votes : 2 (Lapo and Robert) >> url : http://www.scytek.de/cygwin/grace-5.1.12-1.tar.bz2 >> http://www.scytek.de/cygwin/grace-5.1.12-1-src.tar.bz2 >> http://www.scytek.de/cygwin/setup.hint > > Max did a review in: > ~ <http://cygwin.com/ml/cygwin-apps/2003-03/msg00267.html> > > and all proposed changes are applied to the packages at the url > mentioned above.
OK, I've completed the review I began there. I have the following notes: - The warning about gracerc and gracerc.user being overwritten on reinstall is in the README. I'm not sure very many people will read that. I suggest putting it in the comments actually in the files themselves. - You could do change doc to /usr/grace/doc in the README file. This would make it more clear to grace newbies where to find the installed documentation. Neither of these are critical - the current packages could be released as-is - but both of the above are minor improvements that should be considered. Max.
