-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Hi,
I send the last mail before I read your mail Earnie.
|>>> 1. grace |>>> ... |>> Max did a review in: |>> ~ <http://cygwin.com/ml/cygwin-apps/2003-03/msg00267.html> |>> |>> and all proposed changes are applied to the packages at the url |>> mentioned above. |> |> OK, I've completed the review I began there. I have the following notes: |> |> - The warning about gracerc and gracerc.user being overwritten on |> reinstall |> is in the README. I'm not sure very many people will read that. I suggest |> putting it in the comments actually in the files themselves. | | IIRC, this is a major flaw. Package configuration files are to not be | overwritten upon reinstall. You need to use postinstall scripts to | install initial configuration files and not overwrite exsiting | configuration files. If you plan to change the default settings you should use user defined settings, but yes I see the point.
|> - You could do change doc to /usr/grace/doc in the README file. This |> would |> make it more clear to grace newbies where to find the installed |> documentation. | | Uhm, you mean /usr/doc/grace or do you mean /usr/doc/Cygwin/grace.README? The original /usr/grace/README which gets copied to /usr/doc/grace-5.1.12 only talks about the doc directory, grace.README has the full information in it.
|> Neither of these are critical - the current packages could be released |> as-is - but both of the above are minor improvements that should be |> considered. |> | | Not following these conventions are critical IMNSHO.
Ok, if I find a few cycles I will implement the postinstall script.
Volker
- -- PGP/GPG key (ID: 0x9F8A785D) available from wwwkeys.de.pgp.net key-fingerprint 550D F17E B082 A3E9 F913 9E53 3D35 C9BA 9F8A 785D -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (MingW32) Comment: Using GnuPG with Netscape - http://enigmail.mozdev.org
iD8DBQE+cITqPTXJup+KeF0RAmPOAKCKPFWgW2uFEUF4LzoIfHj3rGJHWwCggyUY B4avT/5BMGWeXdHjLl1Egs8= =E7ed -----END PGP SIGNATURE-----
