Hi,
Just noticed that the postinstall mechanism in setup inverts the test for
abnormal exit. The attached one-liner patch fixes that. ChangeLog below.
Igor
==============================================================================
2006-01-23 Igor Peshansky <[EMAIL PROTECTED]>
* script.cc (Script::run): Fix inverted test for abnormal exit.
--
http://cs.nyu.edu/~pechtcha/
|\ _,,,---,,_ [EMAIL PROTECTED] | [EMAIL PROTECTED]
ZZZzz /,`.-'`' -. ;-;;,_ Igor Peshansky, Ph.D. (name changed!)
|,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski
'---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow!
"Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte."
"But no -- you are no fool; you call yourself a fool, there's proof enough in
that!" -- Rostand, "Cyrano de Bergerac"Index: script.cc
===================================================================
RCS file: /cvs/cygwin-apps/setup/script.cc,v
retrieving revision 2.21
diff -u -p -r2.21 script.cc
--- script.cc 14 Oct 2005 04:00:50 -0000 2.21
+++ script.cc 23 Jan 2006 17:07:02 -0000
@@ -243,7 +243,7 @@ Script::run() const
if (to_log && !file_out.isEmpty ())
log(LOG_BABBLE) << file_out << endLog;
- if (!retval)
+ if (retval)
log(LOG_PLAIN) << "abnormal exit: exit code=" << retval << endLog;;
/* if file exists then delete it otherwise just ignore no file error */
