On Thu, 9 Mar 2006, Max Bowsher wrote: > Igor Peshansky wrote: > >> 2006-01-23 Igor Peshansky <[EMAIL PROTECTED]> > >> > >> * script.cc (Script::run): Fix inverted test for abnormal exit. > > > > Ping (attached as "setup-script-exit-code-fix.patch-1"). > > Clearly correct, please commit.
Thanks, done. > >> 2006-01-31 Igor Peshansky <[EMAIL PROTECTED]> > >> > >> * script.cc (Script::run): Fix inverted test for abnormal exit. > >> Do not rename to ".done" unless completed successfully. > > > > And ping (attached as "setup-script-exit-code-fix.patch"). > > Do we necessarily want to try to re-run failed scripts the next time > setup installs some packages? > > Perhaps renaming to ".failed" would be better that not renaming. See the discussion in <http://cygwin.com/ml/cygwin-apps/2006-03/msg00068.html>. Igor -- http://cs.nyu.edu/~pechtcha/ |\ _,,,---,,_ [EMAIL PROTECTED] | [EMAIL PROTECTED] ZZZzz /,`.-'`' -. ;-;;,_ Igor Peshansky, Ph.D. (name changed!) |,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski '---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow! "Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte." "But no -- you are no fool; you call yourself a fool, there's proof enough in that!" -- Rostand, "Cyrano de Bergerac"