On Thu, Sep 27, 2001 at 10:08:34PM +0400, egor duda wrote: >Hi! > >Thursday, 27 September, 2001 Christopher Faylor [EMAIL PROTECTED] wrote: > >>>I'm having some trouble with cvs+ssh with this patch .. though I'm not >>>sure why. For a little while I though it might be chris's tuesday >>>sleep(1) change, because I was getting strange results from pspec> I'm >>>not sure though. > >CF> Huh? What is my "sleep(1)" change? The only change I made on Tuesday was >CF> to fhandler_tty_common::ready_for_read. How would that affect cvs? > >it does. i've seen the following at the end of strace (where ssh >seemed to block in ReadFile() on empty pipe) > > 517 12076688 [main] ssh 7436 peek_socket: considering handle 0x24 > 242 12076930 [main] ssh 7436 peek_socket: adding read fd_set /dev/tcp, fd 4 > 235 12077165 [main] ssh 7436 peek_socket: adding write fd_set /dev/tcp, fd 4 > 291 12077456 [main] ssh 7436 peek_socket: WINSOCK_SELECT returned 1 > 434 12077890 [main] ssh 7436 set_bits: me 0xA013CC0, testing fd 4 (/dev/tcp) > 281 12078171 [main] ssh 7436 set_bits: ready 1 > 242 12078413 [main] ssh 7436 peek_pipe: already ready > 236 12078649 [main] ssh 7436 set_bits: me 0xA013C78, testing fd 0 (/dev/piper) > 241 12078890 [main] ssh 7436 set_bits: ready 1 > 233 12079123 [main] ssh 7436 select_stuff::poll: returning 2 > 242 12079365 [main] ssh 7436 select_stuff::cleanup: calling cleanup routines > 248 12079613 [main] ssh 7436 select_stuff::~select_stuff: deleting select records > 694 12080307 [main] ssh 7436 _read: read (0, 0x24AD7C4, 8192) blocking, sigcatchers >3 > 320 12080627 [main] ssh 7436 peek_pipe: /dev/piper, saw EOF > 261 12080888 [main] ssh 7436 peek_pipe: saw eof on '/dev/piper' > 238 12081126 [main] ssh 7436 fhandler_pipe::ready_for_read: returning 1
I was not disputing the fact that a change that I made could conceivably affect CVS. The fact that you can demonstrate a problem on Thursday does not mean that it was specifically a change that I made on Tuesday. As usual, I can't duplicate this problem. I did see one oddity in some of the new code that I added. I'll check in a patch for that shortly. cgf
