On Fri, 11 Jan 2008, Igor Peshansky wrote:

> On Fri, 11 Jan 2008, Corinna Vinschen wrote:
>
> > On Jan 11 10:11, Igor Peshansky wrote:
> > > So, what was the reason, then, to remove "si.wShowWindow = SW_HIDE" from
> > > spawn_guts in CVS?  Having it makes it much easier to fix run.exe
> > > appropriately...
> >
> > I would be somewhat surprised if this code would have any effect in
> > the trunk.  The code in question looked like this:
> >
> >   if (!wincap.pty_needs_alloc_console () && newargv.iscui && myself->ctty 
> > == -1)
> >     {
> >       si.dwFlags |= STARTF_USESHOWWINDOW;
> >       si.wShowWindow = SW_HIDE;
> >     }
> >
> > Given that pty_needs_alloc_console() is false only on 9x, and is always
> > true on NT, the above code was only executed on 9x.  Since 1.7 dropped
> > 9x support, the code could go away.  Shoot if I missed something.
>
> You didn't, but I'm confused now.  Why would the code that uses execve to
> spawn a Cygwin console process NOT pop up a console window?  Even if the
> parent is compiled with -mwindows, if the app needs a console, one would
> be created, wouldn't it?
>       Igor

Ugh.  ENOCOFFEE.  fhandler_console::need_invisible() takes care of it.  So
run.exe can be changed to use execve even in CVS HEAD.
Sorry for the noise.
        Igor
-- 
                                http://cs.nyu.edu/~pechtcha/
      |\      _,,,---,,_            [EMAIL PROTECTED] | [EMAIL PROTECTED]
ZZZzz /,`.-'`'    -.  ;-;;,_            Igor Peshansky, Ph.D. (name changed!)
     |,4-  ) )-,_. ,\ (  `'-'           old name: Igor Pechtchanski
    '---''(_/--'  `-'\_) fL     a.k.a JaguaR-R-R-r-r-r-.-.-.  Meow!

"That which is hateful to you, do not do to your neighbor.  That is the whole
Torah; the rest is commentary.  Go and study it." -- Rabbi Hillel

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/

Reply via email to