On 06/15/2015 08:40 AM, Nic Bernstein wrote:
On 06/14/2015 07:48 PM, Bron Gondwana wrote:On Tue, Jun 9, 2015, at 08:42 PM, Bron Gondwana wrote:The big news from yesterday's meeting is that we are going to check in a single massive commit which strips all leading tabs from the code, everywhere. The new coding standard is 4 spaces for each level of indent, and spaces for all alignment within code as well.I've pushed a small perl script to master which performs the necessary surgery. it has the smarts to know when a tab isn't on a multiple-of-8 boundary and substitute fewer spaces. The code still builds and passes tests afterwards, so I'm pretty sure it's good. I will be running the on master on June 14th (Sunday) night Melbourne time. That's weekend for everyone, everywhere in the world. I will immediately push the result back to master (after running the tests again of course). If you have a patch series lying around that you want to apply, it might be a good idea to do it before then! Alternatively, you can patch with -l or --ignore-whitespace to apply your patches to the tree, and then run tools/remove-tabs.pl on the resulting tree to remove the tabs again. Enjoy your new, simpler coding style with no trailing whitespace left!This has been done - I didn't quite finish the instructions last night, so I did the work this morning.Bron,Maybe I'm doing something wrong here, but this morning I figured I'd start over clean, so deleted my existing cyrus-docs checkout and grabbed a new one:$ git clone ssh://git@git.cyrus.foundation/diffusion/I/cyrus-docs.gitWhat I ended up with looked suspiciously like the cyrus-imapd tree.
Never mind. Chalk this up to a, um, documentation error. The Phriction wiki page "Using GIT vs. Arcanist" has the wrong URL for the cyrus-docs repository. It should be:
ssh://git@git.cyrus.foundation/diffusion/D/cyrus-docs.git
The URL for cyrus-sasl was also wrong on that page. I've fixed both of
these errors.
Moving on...
-nic
--
Nic Bernstein n...@onlight.com
Onlight, Inc. www.onlight.com
1442 N Farwell Ave., Suite 600 v. 414.272.4477
Milwaukee, Wisconsin 53202
<<attachment: nic.vcf>>
