On 10/13/2016 03:23 PM, ellie timoney via Cyrus-devel wrote:
I think some of the confusion comes from the fact that the setting name -- "archive max size" -- very strongly implies (incorrectly) something like "the largest size of message that will be archived" / "messages larger than this will not be archived at all". It takes a fair bit of attentive reading to overcome that initial implication and reach the correct understanding, that "messages larger than this will be archived immediately, without waiting for archive_days".

But I haven't thought of a better name for this setting either.
My training is originally in both software engineering and Technical Communications and this sounds like a REALLY good argument for changing the name of the setting. "max_size_delayed_archive" -- where are they held if not archived immediately? "max_size_cached_before_archiving" ?

On Fri, Oct 14, 2016, at 09:11 AM, Carlos Velasco via Cyrus-devel wrote:

IMHO, it makes sense when you know how it works, or when you develop the sentence, but the part "won't be archived immediately" is confusing. Sorry I am not native english and this could count, I got confused about the text that's because I had to look into code.

Mmm... I have used right now the (infamous) google translator to check if I am wrong, and translation to spanish (my native) is: "El tamaño en kilobytes del mensaje más grande que no será archivada de inmediato"
Believe me... it is backwards :(

What about something like this instead?
The size, if greater or equal, in kilobytes of the message that will be archived immediately regardless of archive_days setting. Default is 1Mb

Carlos Velasco

-------- Original Message --------
Subject: Re: [Cyrus Imap 3.0] Doc wrong archive_maxsize
From: Bron Gondwana via Cyrus-devel <cyrus-devel@lists.andrew.cmu.edu> <mailto:cyrus-devel@lists.andrew.cmu.edu> To: cyrus-devel@lists.andrew.cmu.edu <mailto:cyrus-devel@lists.andrew.cmu.edu>
Date: 13/10/2016 23:50:11
How is that backwards? (apart from the >= rather than > maybe) If it's bigger than that, then return 1 (archive now), otherwise don't.

On Fri, 14 Oct 2016, at 04:56, Carlos Velasco via Cyrus-devel wrote:

I was testing latest beta of 3.0 and see this new setting:

archive_maxsize: 1024

The size in kilobytes of the largest message that *won’t* be archived immediately. Default is 1Mb

Looking into code this is backwards:

    /* always archive big messages */
    if (record->size >= maxsize)
        return 1;

Reply via email to