Hi,
Robert Bradshaw wrote:
> I looked at all the Pyrex changes and incorporated everything we
> didn't already have
Nice! I noticed you added a couple of things, but I lost track of what was in
and what wasn't. Glad to hear most things are there already.
> except for the GIL and dependancy tracking stuff.
> Someone who actually deals a lot with multi-threaded code should
> probably comment on the GIL stuff,
I'll take a look at it. At first glance, it seems to be mostly bug fixes and a
couple of simplifications, so I don't expect big surprises.
> and the dependancy tracking stuff
> looks mostly good though I'd like to know what you think before
> blindly merging it over.
That looks just fine to me. I did a mostly manual merge and it seems to work
for me.
I also merged (or rather reimplemented) the package resolution stuff that
Pyrex does when searching for include/cimport files. This implies that when
you cimport a .pxd from a package directory such as "package/module.pxd",
there must be a "package/__init__.py[x]" in the search path. Cython didn't
care about that before, but I think it makes sense to restrict package
directory imports to the way Python would do them. That said, both imports
from package directories and those from qualified dotted file names
("package.module.pxd") should work (lxml uses the latter).
Robert, I don't know what naming convention you use in Sage, so could you test
that the changes didn't break it?
Stefan
_______________________________________________
Cython-dev mailing list
[email protected]
http://codespeak.net/mailman/listinfo/cython-dev
