Nicolas, your fix seems good... however, it is still sub-optimal IMHO... setup.py is intended for more things than just building/installing packages. It also should also serve to get package metadata (blame distutils!, but these are the rules). For example, you should be able to do (took one of my projects as an example).
$ python setup.py --fullname petsc4py-1.0.1 $ python setup.py --description PETSc for Python $ python setup.py --author Lisandro Dalcin $ python setup.py --url http://petsc4py.googlecode.com/ So setup.py should not do a lot of work. We have two ways to make this possible. 1) push your patch, but let future Cython releases zip/tarballs ship C sources. 2) implement this the right way, more or less in the spirit of numpy.distutils build_src command. Just to be clear, I'm +1 on your patch. However, I wanted to point out that this still is not the definitive solution. On Mon, Mar 30, 2009 at 11:15 PM, Nicolas Dumazet <[email protected]> wrote: > Hello! > > I opened a few days ago ticket 249 ( > http://trac.cython.org/cython_trac/ticket/249 ) about the build system > which basically recompiles everything on each build, even if nothing > has changed. > > I submitted a patch, which adds a date check on the cython module > files to avoid recompiling the cython parts of the module if the whole > module hasnt been updated since the last generation of the .c files > > Today I'm looking for reviews and comments =) > > Thanks, > > -- > Nicolas Dumazet — NicDumZ [ nɪk.d̪ymz ] > _______________________________________________ > Cython-dev mailing list > [email protected] > http://codespeak.net/mailman/listinfo/cython-dev > -- Lisandro Dalcín --------------- Centro Internacional de Métodos Computacionales en Ingeniería (CIMEC) Instituto de Desarrollo Tecnológico para la Industria Química (INTEC) Consejo Nacional de Investigaciones Científicas y Técnicas (CONICET) PTLC - Güemes 3450, (3000) Santa Fe, Argentina Tel/Fax: +54-(0)342-451.1594 _______________________________________________ Cython-dev mailing list [email protected] http://codespeak.net/mailman/listinfo/cython-dev
