Just opened ticket, http://trac.cython.org/cython_trac/attachment/ticket/274/
The patch is two lines, obviously trivial (for any one with some knowledge of Python C-API). I've spent more time opening the ticket and deciding the right Type & Priority tags than working on the fix. And of course, sum up the time to write this comment ;-). Do we really need to be so strict about this patch requires ticket policy? On Wed, Mar 11, 2009 at 8:17 PM, Robert Bradshaw <[email protected]> wrote: > On Mar 11, 2009, at 9:01 AM, Lisandro Dalcin wrote: > >> On Wed, Mar 11, 2009 at 12:43 PM, Dag Sverre Seljebotn >> <[email protected]> wrote: >>> Lisandro Dalcin wrote: >>>> Likely Dag should review this... If you agree on the patch, please >>>> push ... IMHO, this fix should go to 0.11 > > The patch looks good, can you make a ticket for it? Also, can you use > mercurial to output diffs so we get your name and a comment with it > as well? > >>> a) Saying that this should go into 0.11 means saying that this >>> specific >>> bug is more important than everything else that sits in milestone >>> 0.11.1 >>> in Trac. We probably put out 0.10 with the same bug and the Cython >>> project survived! We need to have some disipline and get things >>> released >>> -- release early, release often. > > Yes, we need to return to the "release early, release often" > schedule. We can start putting patches up and getting reviews for > them on trac for 0.11.1 right away. I've added milestone 0.11.2, > everything that doesn't have a patch or easy fix for 0.11.1 will get > moved there so we can release 0.11.1 shortly. > >> I understand that... I just wanted to point that this fix likely does >> not have high impact and fix 64 bits issues, more or less like recent >> Robert's pushes did. > > > The last push was to facilitate getting cython 0.11 into the rpm > repo, though in retrospect I guess it's lower priority than some > other stuff. At this point, unless there's a major bug, the only > thing I can see adding is perhaps testcases. > > - Robert > _______________________________________________ > Cython-dev mailing list > [email protected] > http://codespeak.net/mailman/listinfo/cython-dev > -- Lisandro Dalcín --------------- Centro Internacional de Métodos Computacionales en Ingeniería (CIMEC) Instituto de Desarrollo Tecnológico para la Industria Química (INTEC) Consejo Nacional de Investigaciones Científicas y Técnicas (CONICET) PTLC - Güemes 3450, (3000) Santa Fe, Argentina Tel/Fax: +54-(0)342-451.1594 _______________________________________________ Cython-dev mailing list [email protected] http://codespeak.net/mailman/listinfo/cython-dev
