Lisandro Dalcin wrote: > Yes, it seems to fix the issue... Just tested from a fresh SVN update > with the latest patch applied.
Cool, well done. > BTW, I'm getting this failure in Py3k... we should handle this, though > not sure about what to do. > > extdelslice.cpp:464: error: invalid conversion from int > (*)(PyObject*, Py_ssize_t, Py_ssize_t, PyObject*) to void* > extsetslice.cpp:466: error: invalid conversion from int > (*)(PyObject*, Py_ssize_t, Py_ssize_t, PyObject*) to void* I think a warning that __*slice__() isn't portable would be nice. Apart from that, I wouldn't care too much. Maybe remove the test alltogether. > I'm also getting other failures, some are changes in exception > messages, other are related to division .... Exception message changes are ugly. My take is: if Cython generates a similar exception or compiler error, try to follow Py3 regarding the message (if it makes sense, but there's usually a reason why they did it). In our doctests, try to check as much of an exception as possible to avoid false positives. But I agree that it's really tricky to check these things in a portable way. > This one is very nince :-) > > <...> in complex_numbers_T305 > Failed example: > test_arithmetic(2j, 4j) > Expected: > (-2j, 6j, -2j, (-8+0j), (0.5+0j)) > Got: > ((-0-2j), 6j, -2j, (-8+0j), (0.5+0j)) Beautiful. :) We do a lot of doctest string manipulation already, so that's just another case IMHO. Stefan _______________________________________________ Cython-dev mailing list [email protected] http://codespeak.net/mailman/listinfo/cython-dev
