Ed Leafe wrote:
> On Jun 19, 2008, at 2:24 PM, Ed Leafe wrote:
>
>>> Ah, they originally were event handlers, but now they are called by
>>> the
>>> event handlers. I think on*() is good, but it is unfortunate this is
>>> likely to break existing code.
>> I'll just change the signature for them to: onOK(self, evt=None)
That'll work, but is ugly. Slightly better would be passing on the
original event, so at least there's a purpose for it.
Perhaps this:
try:
self.onOk()
except TypeError, e:
if "takes exactly 2 arguments" in str(e):
deprecation_warning("...")
self.onOk(evt=None)
> One other thing that I noticed: the ReleaseOnEscape property is
> broken, and was in the old version. To see, revert to rev.4028, and
> run the self-test. When the first plain dDialog appears, press Escape:
> you'll get a traceback for a dead object exception. That's because
> ReleaseOnEscape doesn't just tie the Escape key to the cancel button
> (if any), but it actually destroys the dialog. So if we want the
> cancel button to work with Escape, we can access the dialog if they
> click the cancel button, but not if they press Escape.
>
> Can we change this to 'CancelOnEscape'? And change the behavior to
> not release the dialog? Will that break anything?
+1 remove ReleaseOnEscape from dDialog.
+1 add CancelOnEscape to the OK/Cancel dialog
Paul
_______________________________________________
Post Messages to: [email protected]
Subscription Maintenance: http://leafe.com/mailman/listinfo/dabo-dev
Searchable Archives: http://leafe.com/archives/search/dabo-dev
This message: http://leafe.com/archives/byMID/[EMAIL PROTECTED]
