On Jun 19, 2008, at 2:49 PM, Paul McNett wrote:

>>>     I'll just change the signature for them to: onOK(self, evt=None)
>
> That'll work, but is ugly. Slightly better would be passing on the
> original event, so at least there's a purpose for it.
>
> Perhaps this:
>
> try:
>   self.onOk()
> except TypeError, e:
>   if "takes exactly 2 arguments" in str(e):
>     deprecation_warning("...")
>     self.onOk(evt=None)


        And you think that that is less ugly?  ;-)

        The only reason for adding the optional parameter is backwards  
compatibility. It simply isn't needed anymore. These are wx-level  
events, so passing it would cause more problems if anyone was  
expecting Dabo events.

>>      Can we change this to 'CancelOnEscape'? And change the behavior to
>> not release the dialog? Will that break anything?
>
> +1 remove ReleaseOnEscape from dDialog.
> +1 add CancelOnEscape to the OK/Cancel dialog

        OK, cool. I like that.

-- Ed Leafe





_______________________________________________
Post Messages to: [email protected]
Subscription Maintenance: http://leafe.com/mailman/listinfo/dabo-dev
Searchable Archives: http://leafe.com/archives/search/dabo-dev
This message: http://leafe.com/archives/byMID/[EMAIL PROTECTED]

Reply via email to