On 02/03/2011 19:27, Paul McNett wrote: > On 3/2/11 10:04 AM, Werner F. Bruhin wrote: >> On 02/03/2011 18:28, Nate Lowrie wrote: >>> On Wed, Mar 2, 2011 at 12:20, Paul McNett<[email protected]> wrote: >>>> On 3/2/11 3:22 AM, Werner F. Bruhin wrote: >>>>> Not that I would always remember but any chance that this >>>>> >>>>> http://trac.edgewall.org/browser/branches/0.11-stable/contrib/trac-post-commit-hook >>>>> >>>>> or similar could be activated on the dabo trac? >>>> Personally, it smells too implicit to me. I vote -1. >>> -1 from me to because of the implicit nature. >>> >> Why do both of you consider this solution implicit? Commiter has to >> add specific text to make this work. >> >> Who is expected to close the tickets? The commiter or the reporter? >> >> I think it should be the commiter, if ever it isn't really fixed then >> the reporter can always reopen it. > So far it is +1 for, -2 against. I'm willing to try it if it gains support. I > just > don't see a big need being addressed here, and possible detriments. We want > developers interacting with the trac system, not overly enabled to avoid it. > > Yes, the committer should ideally close the ticket. > > What if a commit log went something like "I think this probably fixes ticket > #5555 > but not quite sure so I'm keeping it open for now"? In this case it would be nice if there would be a status "needs testing", but as there isn't it should be left open and the commit should use instead of "fixed #1000101" use "refs #1000101", so the reporter sees that something has happened but it is not sure that it is totally fixed.
If no one else besides me wants this then just leave it as is. Werner _______________________________________________ Post Messages to: [email protected] Subscription Maintenance: http://leafe.com/mailman/listinfo/dabo-dev Searchable Archives: http://leafe.com/archives/search/dabo-dev This message: http://leafe.com/archives/byMID/[email protected]
