On Sat, Nov 19, 2005 at 12:38:28PM -0500, [EMAIL PROTECTED] wrote:
> So, for any interested parties, I'd appreciate it if you could comment on if
> the feature seems useful and if the implementation is okay. Also, given that
> I
> don't really know Haskell, any comments on my coding style would be much
> appreciated.
> validFileChars :: Char -> Bool
> mapFileChars :: Char -> Char
I'm rather novice at Haskell myself, but regardless of language
I would have named these functions something ending with
'Char' and not 'Chars' since they operate on a single char.
> quickCheck $ \s ->
> unlines ("":s++["", ""]) ==
> unpackPS (read_email (renderPS
> $ make_email "reponame" (text "contents\n") "textname"
> $ text $ unlines s))
This does not compile (wrong order of arguments). I think it should be:
quickCheck $ \s ->
unlines ("":s++["", ""]) ==
unpackPS (read_email (renderPS
$ make_email "reponame" (text "contents\n")
(text $ unlines s) "textname"))
As for the usefulness: One thought is to use the name of
the last patch. There is a suggestion to put the last patch
name in the subject line of the mail (instead of the first),
and I think it has some merit, for example in the case where
you include old but not yet applied patches only to fulfill
dependencies.
--
Tommy Pettersson <[EMAIL PROTECTED]>
_______________________________________________
darcs-devel mailing list
[email protected]
http://www.abridgegame.org/cgi-bin/mailman/listinfo/darcs-devel
