On 12/14/05, Juliusz Chroboczek <[EMAIL PROTECTED]> wrote: > Looks good to me, except that you need to filter out special > characters. The characters you include in the filename should be > > - okay for MIME (no quotes, and probably some others); > - okay for Unix (no slashes); > - okay for Windows (no lots of stuff). > > The safe thing would be to replace anything that's not in > [-_0-9a-zA-Z] with a dash.
Juliusz, It was already filtering out special characters. But I did modify the filtering a bit from how it used to be. Now it keeps underscores and spaces are changed to underscores. I also cleaned up the code a bit. If DarcsArguments supports optional parameters to options, it might be nice to add this support to -o. If a filename (or -) is supplied, it behaves as it does now. But if neither are supplied, it writes to the automatically generated filename. I haven't spent a lot of time looking at DarcsArguments yet so I don't know if it supports this. > I'll be glad to apply this to darcs-unstable after you've made the > above change. Thanks for your comments. Please let me know how the attached patch is. -- Zachary P. Landau <[EMAIL PROTECTED]>
added_autonaming_of_attachment_created_by_send_v3.dpatch
Description: Binary data
_______________________________________________ darcs-devel mailing list [email protected] http://www.abridgegame.org/cgi-bin/mailman/listinfo/darcs-devel
