On Wed, May 21, 2008 at 11:18 AM, Reinier Lamers <[EMAIL PROTECTED]> wrote: > > Op 21-mei-2008, om 19:47 heeft zooko het volgende geschreven: > >> On May 21, 2008, at 11:28 AM, [EMAIL PROTECTED] wrote: >> >>> Wed May 21 00:16:31 CEST 2008 [EMAIL PROTECTED] >>> * resolve issue777: reduce memory usage of darcs put >>> >>> I did it by creating an incremental version of the SHA-1 >>> function. I have to >>> make some unit tests for it, because I don't trust such an >>> important function >>> without those. >> >> Cool! >> >> And you are wise to require unit tests for such a function. > I made some and ran them, so I'm quite convinced now that the code is > correct. I'll send a bottle of beer by mail to anyone who spots a bug > in the code with his bare eye. > > But the QuickCheck framework appears to be in the src/Darcs/Patch > directory (so specifically intended for the patch functions?). Is > there anyone who would complain if I moved the QuickCheck tests to > the src/ directory and added the SHA-1 tests?
That's not just the QuickCheck framework, those are the quickcheck tests for patches, and they should remain where they are. You could refactor out anything you find generally useful into a driver framework, though, and move that. And then add a third module with your quickcheck tests. David P.S. Be sure to run timings and memory tests without --enable-profile! Also, please extend the microbench program to allow easy testing and timing of your sha1PSs, as it allows testing and timing of sha1PS. _______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
