On Thu, May 22, 2008 at 04:25:05AM -0700, David Roundy wrote: > On Thu, May 22, 2008 at 4:22 AM, Reinier Lamers <[EMAIL PROTECTED]> wrote: > >> Did you actually test that this affects the memory use of put? It'd > >> greatly surprise me if it affected our memory use by more than a > >> couple of percent, and for such a small gain, I'm not convinced it's > >> worth the complexity. Of course, it could also either improve or hurt > >> the cpu time used in put and apply, and I'd be interested in knowing > >> which effect it has. > > > > On my box, the memory usage went from 1 gigabyte and counting to 64 MB for > > the particular phase in which it consumed too much memory, and the maximum > > memory usage during the whole "darcs put" went from more than one gig to > > about 200 MB. > > Wow. What is the size of this test repository?
Based on your inspiring report, I just ran a test darcs put of the darcs repository, and it didn't look so encouraging. I only measured the memory by watching top, but there didn't seem to be any difference--both peaked out at a bit over 500 MB. And the time with your patch was 1m46.446s versus 1m24.526s without. I only ran the two timings, and it's possible that I couldn't see the peak memory use. But I can't help but wonder, did you run your testing with profiling enabled, by any chance? -- David Roundy Department of Physics Oregon State University _______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
