On Thu, Sep 04, 2008 at 09:51:56 -0400, David Roundy wrote: > > > - :>: reverseRL (concatRL $ unsafeUnflippedseal $ > > > get_patches_beyond_tag chtg patches) > > > + :>: reverseRL (concatRL $ unsafeUnflippedseal $ > > > get_patches_beyond_taginfo chtg patches) > > > > Hmm. Would a darcs replace not have been practical or sensible here? > > I'm curious as to the motivation for this renaming. It seems to me > that get_patches_beyond_tag is more accurate than > get_patches_beyond_taginfo. True, the tag is described by a > PatchInfo, but it is the tag itself that we're getting the patches > that are beyond.
I guess only Jason can say for sure, but I suspect the intention is to eventually get back to using get_patches_beyond_tag, with the taginfo variant just being its slightly typewitness-impaired cousin. In other words, the name may not matter so much, and the info variant isn't meant to stick around for very long. But I could be completely off... > > My understanding of this function (and Jason's more typeful version) is > > that it retrieves the patches that come "chronologically after" a tag. > > We just walk down the entire patchset, returning each patch in sequence > > /until/ we hit the tag in question. This is the case below > > I would avoid the terminology "chronologically after", and just say > that it retrieves the patches that aren't in the tag. Yes! Much clearer. I think I was led down this path by the word 'beyond'. Maybe some sort of renaming is in order, although get_patches_not_in_tag does sound a bit clunky. Anyway, I'll submit some sort of documentation patch when the dust settles. -- Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow> PGP Key ID: 08AC04F9
signature.asc
Description: Digital signature
_______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
