On Thu, Sep 4, 2008 at 7:00 AM, Eric Kow <[EMAIL PROTECTED]> wrote: > On Thu, Sep 04, 2008 at 09:51:56 -0400, David Roundy wrote: >> > > - :>: reverseRL (concatRL $ unsafeUnflippedseal $ >> > > get_patches_beyond_tag chtg patches) >> > > + :>: reverseRL (concatRL $ unsafeUnflippedseal $ >> > > get_patches_beyond_taginfo chtg patches) >> > >> > Hmm. Would a darcs replace not have been practical or sensible here? >> >> I'm curious as to the motivation for this renaming. It seems to me >> that get_patches_beyond_tag is more accurate than >> get_patches_beyond_taginfo. True, the tag is described by a >> PatchInfo, but it is the tag itself that we're getting the patches >> that are beyond. > > I guess only Jason can say for sure, but I suspect the intention is to > eventually get back to using get_patches_beyond_tag, with the > taginfo variant just being its slightly typewitness-impaired cousin. > In other words, the name may not matter so much, and the info variant > isn't meant to stick around for very long. But I could be completely > off...
Eric is right. Originally I completely removed the old version in favor of the new one. Later I discovered that it requires more refactoring than I was prepared for to do that. So, I sneaked the original back in. Changing the name to something new meant that I was able to explicitly see all the places that use each version. I'm not tied to the new name. If you have a different name I'll happily send in replace patches to tidy up. And to answer Eric's earlier question about replace patches; it's simply that I don't (yet) think in terms of replace patches. You could call it user error. The only reason I changed it to take a PatchInfoAnd was that I needed the patch's context in order to return the proper context. I see some other functions in this module that could also be made into more typeful versions someday as well. > I think I was led down this path by the word 'beyond'. Maybe some sort > of renaming is in order, although get_patches_not_in_tag does sound a > bit clunky. I think we already have some not_in_tag variants floating around in other modules. Beyond is a very good word here assuming that you have the right mental context already (haddock will help with that). If we were to choose a more accurate word we would need one that roughly means, "independent of and sitting at the end of the sequence". Or maybe the "independent of" is redundant in our case. Thanks, Jason _______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
