On Mon, Sep 22, 2008 at 03:04:15PM +0000, [EMAIL PROTECTED] wrote: > Mon Sep 22 15:43:04 BST 2008 Eric Kow <[EMAIL PROTECTED]> > * Refactor file checking in add command.
Did you have some future plans to expand this refactor? As it is, it doesn't look like an improvement to me. You've increased the total number lines, and could probably have gained approximately the same amount of clarity by reindenting the existing code the same way you indented getFileType. However, if you're thinking to move getFileType into a different module and then implement it with a single call to getSymbolicLinkStatus, that would be a different matter, as it could achieve increased code clarity and efficiency at the same time. David _______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
