On Mon, Sep 22, 2008 at 12:28:32 -0400, David Roundy wrote: > Did you have some future plans to expand this refactor? As it is, it > doesn't look like an improvement to me. You've increased the total > number lines, and could probably have gained approximately the same > amount of clarity by reindenting the existing code the same way you > indented getFileType. However, if you're thinking to move getFileType > into a different module and then implement it with a single call to > getSymbolicLinkStatus, that would be a different matter, as it could > achieve increased code clarity and efficiency at the same time.
Yeah, I was actually just working on issue53 (which I could do without the refactor actually). Anyway, let me send you the bundle. -- Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow> PGP Key ID: 08AC04F9
signature.asc
Description: Digital signature
_______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
