On Thu, Sep 25, 2008 at 11:06:23AM -0700, Dmitry Kurochkin wrote: > Is there any reason not to use System.Directory.canonicalizePath in > ioAbsolute? It seems to do just what we need.
The main reason would be that there doesn't seem to be any documentation indicating what System.Directory.canonicalizePath does. It could be there's some in the source, but the haddock docs aren't adequate. If it doesn't do exactly what we want, we'll have to reimplement it anyhow. I'm also still not entirely comfortable with the decision to rely on the filepath package and break compatibility with ghc 6.4, so I'd rather keep the number of uses down, for the moment. A minor factor would be that canonicalizePath would most likely produce paths on windows that we'll have to munge to get the slashes forward. > Thu Sep 25 21:57:11 MSD 2008 Dmitry Kurochkin <[EMAIL PROTECTED]> > * Make FileName.drop_dotdot work with absolute paths. Looks safe, although I'd prefer to move in the direction of not using the FileName code in the RepoPath module, and to move back to only using FileName for paths within a repository (which is what it was written for). > Thu Sep 25 21:57:26 MSD 2008 Dmitry Kurochkin <[EMAIL PROTECTED]> > * Resolve issue1078: make ioAbsolute work with symbolic links in file paths. > > Thu Sep 25 22:01:03 MSD 2008 Dmitry Kurochkin <[EMAIL PROTECTED]> > * Move issue1078 test from bugs to tests. Looks good. Applied. David _______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
