> > Thu Sep 25 21:57:11 MSD 2008 Dmitry Kurochkin <[EMAIL PROTECTED]> > > * Make FileName.drop_dotdot work with absolute paths. > > Looks safe, although I'd prefer to move in the direction of not using > the FileName code in the RepoPath module, and to move back to only > using FileName for paths within a repository (which is what it was > written for).
Thanks for clarifying that! I thought that was the case (in which case, by rights the FileName code should neither absolute paths nor "../foo/bar" (although "foo/../bar" should be ok). After 2.1.0, we really ought to tidy up our file path handling and make more of these assumptions explicit. It might be good to move FileName into Darcs.Repository.FileName and also make sure that we are only using SubPath within a repository. Slurpies should probably also only be using SubPath. -- Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow> PGP Key ID: 08AC04F9
pgpN1fXaVxkFW.pgp
Description: PGP signature
_______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
