Hi Eric.
On Sat, Nov 8, 2008 at 1:02 PM, Eric Kow <[EMAIL PROTECTED]> wrote:
> Hi Marc,
>
> To ensure that darcs builds, I have submitted a patch to disable -Werror
I vote against disabling -Werror. I sometimes miss warnings in build
output. And -Werror guarantees that I would not miss it. I think we
should disable -Werror only if there is no way around it (or it is too
ugly). Conditional compilation for language extensions looks fine to
me.
Regards,
Dmitry
>
> On Sat, Nov 08, 2008 at 06:13:22 +0100, Marc Weber wrote:
>> Probably the best way is pasing -cpp all the time by default and then
>> using something like this:
>>
>> #if (__GLASGOW_HASKELL__ > 608)
>> {-# OPTIONS_GHC -fbang-patterns -fffi #-}
>> #else
>> {-# LANGUAGE BangPatterns, ForeignFunctionInterface #-}
>> #endif
>
> Does anybody have comments about this approach (aside from what seems to
> be the inverted then/else?)
>
> Thanks,
>
> P.S. Note also that the devel list is only used for automated traffic,
> that is, from the buildbot and the bug tracker. Please use the
> users list instead.
>
> --
> Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
> PGP Key ID: 08AC04F9
>
> _______________________________________________
> darcs-users mailing list
> [email protected]
> http://lists.osuosl.org/mailman/listinfo/darcs-users
>
>
_______________________________________________
darcs-users mailing list
[email protected]
http://lists.osuosl.org/mailman/listinfo/darcs-users
