Hi.
Sorry for taking so much time. I did not find time to complete review
on weekend. Here are comments for the last patch.
Not so nice formatted, I will try to do better next time :)
[Avoid exporting cleanupRepositoryReplay.
Petr Rockai <[EMAIL PROTECTED]>**20081106000049
---------------------------------------------
hunk ./src/Darcs/Repository/Repair.hs 101
-replayRepository :: (RepoPatch p) => Repository p -> [DarcsFlag] ->
IO (RepositoryConsistency p)
-replayRepository repo opts = do
+replayRepository' :: (RepoPatch p) => Repository p -> [DarcsFlag] ->
IO (RepositoryConsistency p)
+replayRepository' repo opts = do
Old function is renamed, and not exported anymore.
hunk ./src/Darcs/Repository/Repair.hs 147
+
+replayRepository :: (RepoPatch p) => Repository p -> [DarcsFlag] ->
(RepositoryConsistency p -> IO a) -> IO a
+replayRepository r opt f = do
+ st <- replayRepository' r opt
+ ret <- f st
+ cleanupRepositoryReplay r
+ return ret
Main change, new replayRepository takes an action to perform and does cleanup.
I think it would be better to use bracket here.
hunk ./src/Darcs/Commands/Check.lhs 92
No functional changes, new api is used. cleanupRepositoryReplay
is removed since it is called by replayRepository now.
hunk ./src/Darcs/Commands/Repair.lhs 71
Same here.
hunk ./src/Darcs/Commands/Repair.lhs 84
putStrLn "Fixing pristine tree..."
replacePristineFromSlurpy repository s
return ()
- cleanupRepositoryReplay repository
return () can be removed here. Note this is not introduced in this patch.
Regards,
Dmitry
_______________________________________________
darcs-users mailing list
[email protected]
http://lists.osuosl.org/mailman/listinfo/darcs-users
