Hi, thanks for review.
"Dmitry Kurochkin" <[EMAIL PROTECTED]> writes: > +replayRepository :: (RepoPatch p) => Repository p -> [DarcsFlag] -> > (RepositoryConsistency p -> IO a) -> IO a > +replayRepository r opt f = do > + st <- replayRepository' r opt > + ret <- f st > + cleanupRepositoryReplay r > + return ret > > Main change, new replayRepository takes an action to perform and does cleanup. > I think it would be better to use bracket here. Ah, good catch! I often tend to forget bracketing. :| It's not a disaster, as it'll just leave stale files around till next time pristine is touched, but it'd still be better to bracket. I will send an amended patch that adds a `finally` handler in a bit. Yours, Petr. -- Peter Rockai | me()mornfall!net | prockai()redhat!com http://blog.mornfall.net | http://web.mornfall.net "In My Egotistical Opinion, most people's C programs should be indented six feet downward and covered with dirt." -- Blair P. Houghton on the subject of C program indentation _______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
