Thanks for the review! Could you submit an alternative to this patch? In particular...
On Thu, Jan 01, 2009 at 15:20:54 +1100, Trent W. Buck wrote: > > hunk ./src/configuring_darcs.tex 274 > > you can set the environment variable DARCS\_DONT\_ESCAPE\_ISPRINT to 1 > > and darcs will display all the printables in the current system locale > > instead of just the ASCII ones. > > -NOTE: This curently does not work on some architectures if darcs is > > -compiled with GHC~6.4. Some non-ASCII control characters might be printed > > -and can possibly spoof the terminal. > > I think this is wrong; "Some non-ASCII control characters might be > printed -and can possibly spoof the terminal" still applies to current > versions. I'm not sure what to do about this one. Do we just get rid of the 'if darcs is compiled with GHC 6.4'? -- Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow> PGP Key ID: 08AC04F9
signature.asc
Description: Digital signature
_______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
