Eric Kow <[email protected]> writes:

> Thanks for the review!
>
> Could you submit an alternative to this patch?  In particular...
>
> On Thu, Jan 01, 2009 at 15:20:54 +1100, Trent W. Buck wrote:
>> > hunk ./src/configuring_darcs.tex 274
>> >  you can set the environment variable DARCS\_DONT\_ESCAPE\_ISPRINT to 1
>> >  and darcs will display all the printables in the current system locale
>> >  instead of just the ASCII ones.
>> > -NOTE: This curently does not work on some architectures if darcs is
>> > -compiled with GHC~6.4. Some non-ASCII control characters might be printed
>> > -and can possibly spoof the terminal.
>> 
>> I think this is wrong; "Some non-ASCII control characters might be
>> printed -and can possibly spoof the terminal" still applies to current
>> versions.

Hmm, on sober reflection I think I was confusing _ISPRINT with
_ANYTHING.

The caveat was originally added by the following changeset; Tommy, are
you still around and do you have an opinion on what, if anything, should
go here?

Sun Nov 13 02:36:28 EST 2005  Tommy Pettersson <[email protected]>
  * add note in docs about bug with DARCS_DONT_ESCAPE_ISPRINT with GHC 6.4
    hunk ./configuring_darcs.tex 204
    +NOTE: This doesn't work if darcs is compiled with GHC~6.4 or later.
    +Some non-ASCII control characters might be printed and possibly spoof the 
terminal.
    +It is a known bug in darcs and will be fixed in a future release.

_______________________________________________
darcs-users mailing list
[email protected]
http://lists.osuosl.org/mailman/listinfo/darcs-users

Reply via email to