On Thu, Jan 15, 2009 at 20:16:53 +1100, Trent W.Buck wrote: > Sending this one separately because it's relatively long. > > Thu Jan 15 14:45:12 EST 2009 Trent W. Buck <[email protected]> > * Refactor logic flow in `main`. Applied, thanks! This gives an appreciable improvement to code clarity.
Lest my recent review to another bundle send the wrong message, I really *do* such refactors and 'minor' patches (they add up). I just wanted to throw in an 'in case of doubt' and also to point out that some situations deserve more doubt. Refactor logic flow in `main`. ------------------------------ > Trent W. Buck <[email protected]>**20090115034512 > Ignore-this: 182db125fbd030cb3f8b442ef1822155 > ] hunk ./src/darcs.hs 55 > main = with_atexit $ withSignalsHandled $ > + argv <- getArgs > when (length argv < 1) $ > do print_version ... > + when (length argv == 1) $ do > + let argv0 = head argv Since we have all that fancy pattern matching, we might be better off just using a case statement on argv to avoid the use of head. -- Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow> PGP Key ID: 08AC04F9
signature.asc
Description: Digital signature
_______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
