On Thu, Jan 15, 2009 at 10:11:18AM +0000, Eric Kow wrote:
> Refactor logic flow in `main`.
> ------------------------------
> > -  when (length argv == 1 && (argv!!0 == "--exact-version")) $
> > -       do putStrLn $ "darcs compiled on "++__DATE__++", at "++__TIME__
> > -          putStrLn context
> > -          exitWith $ ExitSuccess
> > -  when (length argv == 1 && argv!!0 == "--commands") $
> > -       do list_available_commands
> > -          exitWith $ ExitSuccess
> 
> That these two (exitWith $ ExitSuccess) had gone away... I suspect that
> this was related to the tests failing, i.e. that some test and possibly
> some plausible usage of darcs involves the use of -v or --commands as
> the first of many arguments passed to the darcs executable.

Hmm, I made them have a common exitWith at the bottom of the "outer"
when's body.  Maybe I've misunderstood how WHEN works in Haskell?

> Could you correct this?  Maybe this would be a good chance to sneak in
> the pattern-match and case idea?

Agreed.
_______________________________________________
darcs-users mailing list
[email protected]
http://lists.osuosl.org/mailman/listinfo/darcs-users

Reply via email to