Thanks to Ferenc Wagner for the suggestion.

Note: I'm not spoofing the author field because it seems to annoy
people when the patch is merely *derived* from the spoofee, rather
than being their work verbatim.

Sat Jan 17 21:29:28 EST 2009  Trent W. Buck <[email protected]>
  * Refactor add_to_list.

New patches:

[Refactor add_to_list.
Trent W. Buck <[email protected]>**20090117102928
 Ignore-this: 73c639dcba23a2abd3577e1d1e593384
] hunk ./src/Darcs/Repository/Prefs.lhs 380
      then mWriteBinFile (fp2fn $ prefs ++ p) (unlines ls)
      else return ()
 
+-- | Add element @x@ to list @xs@ if it isn't there yet.
 add_to_list :: Eq a => a -> [a] -> [a]
hunk ./src/Darcs/Repository/Prefs.lhs 382
-add_to_list s [] = [s]
-add_to_list s (s':ss) = if s == s' then (s:ss) else s': add_to_list s ss
+add_to_list x xs = if x `elem` xs then xs else x : xs
 
 def_prefval :: String -> String -> IO String
 def_prefval p d = do

Context:

[Refactor initial argument dispatcher.
Trent W. Buck <[email protected]>**20090117081533
 Ignore-this: fe101e61cc7b46a8c6b4415f08c737b
] 
[Simplify some of my own code.
Trent W. Buck <[email protected]>**20090117015505
 Ignore-this: 42a7df5c21ae0416441572380490e127
] 
[Refactor: use more guards.
Trent W. Buck <[email protected]>**20090115072617
 Ignore-this: b41bb970198ed1f42aebdfc63c90e115
] 
[Resolve issue1311:  Use time zones from GNU coreutils; improve doc.
Dave Love <[email protected]>**20090112135012
 Ignore-this: 883bc4ccdb1d27fde14ec9c76a4d2a45
] 
[omit empty line at the end of output in darcs diff
Christian Kellermann <[email protected]>**20090114110607
 Ignore-this: d71a3d5460fbe21244c4eba77dc47885
] 
[Clean up when previous test crashed.
Trent W. Buck <[email protected]>**20090113001345] 
[Make "make clean" remove microbench.
Trent W. Buck <[email protected]>**20090111152130
 Put the clean target directly below the build target, so it's harder
 to get them out of sync in future.
] 
[Fix test optimize_relink.sh when no hard linking available
Thorkil Naur <[email protected]>**20090113223335
 The semicolon in the echo command causes the test to fail with the
 message
 
 > optimize_relink.sh: line 37: assuming: command not found
 
 when no hard linking is available.
] 
[Consistently use sh (not csh) prompts in user manual.
Trent W. Buck <[email protected]>**20090111114801
 
 The sh prompt ($) was already used elsewhere in the manual, and I
 choose to standardize on it instead of csh (%) because sh (especially
 bash) seems more widespread and recognizable as the user shell prompt.
] 
[resolve issue1270: don't show the motd when --xml-output is given
[email protected]**20090109090726
 Ignore-this: e1dae49ceb510668a1358e2103268cc3
] 
[Get setpref description in manual.
Dave Love <[email protected]>**20090111151941
 Ignore-this: 89b0d00a82582d03fdf51cd9822dba65
] 
[Example for issue1284.
Trent W. Buck <[email protected]>**20090111051101] 
[resolve issue1235: added --summary to obliterate
Rob Hoelz <[email protected]>**20090110032907] 
[Haddock for Darcs.Repository.Format
Florent Becker <[email protected]>**20090108160035
 Ignore-this: f88f0223ebbbe5694845dd1060e6f978
] 
[Remove stale comment (we now require GHC 6.6)
Eric Kow <[email protected]>**20081231080929
 Ignore-this: b19da9fabc8d2e38bccafc84a77fa278
] 
[do not use concatenation in src/Context.hs
Florent Becker <[email protected]>**20090107135552
 Ignore-this: 9e86505a445730b7653e75f08e8ff81e
] 
[Print malicious paths and optional way around them when they cause a failure.
David Caldwell <[email protected]>**20090105101628
 Ignore-this: cdb706087869e19e046bc0dd424ca38d
] 
[Fix typo in --dont-restrict-paths documentation.
David Caldwell <[email protected]>**20090105024208
 Ignore-this: 16197eeef34dedddeda036b47747f234
] 
[Add --restrict-paths (and --dont-restrict-paths) to "darcs apply".
David Caldwell <[email protected]>**20090102101737
 Ignore-this: f6ab937573bf0d5397361ddefed902c9
] 
[Add --restrict-paths (and --dont-restrict-paths) to "darcs pull".
David Caldwell <[email protected]>**20090102101726
 Ignore-this: dd3bc04632d341be16709e0aee6753ec
] 
[Revert --restrict-paths removal.
David Caldwell <[email protected]>**20090102101705
 Ignore-this: 1fba1f9a589aaabb1fa27a268f7c972e
] 
[Resolve issue1302: set closed bugs to resolved (not resolved-in-unstable).
Trent W. Buck <[email protected]>**20090105001351] 
[make stringify cut the string
[email protected]**20090104102125
 Ignore-this: e1a0cd83fce5085f60b812d894ca26e7
 This avoids choking utilities such as grep (or emacs' internal grep) which parse haskell files line-by-line.
] 
[make unit's return value depend on all tests
Florent Becker <[email protected]>**20090102184930
 Ignore-this: fce3636c70bcb4a80413823c88e3ac6a
] 
[Resolve issue1285: remove "cabal test" intermediaries.
Trent W. Buck <[email protected]>**20090103095347] 
[Resolve issue1206: Countable Nouns.
Trent W. Buck <[email protected]>**20090101062452
 Use the conventional term "Countable" instead of "Numbered".
] 
[Improve readability of bug reporting.
Trent W. Buck <[email protected]>**20081226120833
 Moving "at <location>" to the first line gives the descriptive string
 a line all to itself.  For example, darcs show bug:
 
     darcs: bug at src/Darcs/Commands/ShowBug.lhs:57 compiled Nov  4 2008 12:05:43
     This is actually a fake bug in darcs.
] 
[Use imperative mood for primitive matcher help.
Trent W. Buck <[email protected]>**20081228114434] 
[Check GADT witnesses when doing Cabal-based builds.
Petr Rockai <[email protected]>**20081228111229] 
[Fix haddock error
Eric Kow <[email protected]>**20081227204218
 Ignore-this: 60f05d20e5f37312f6b477067114fac7
] 
[Haddock for primitiveMatchers (untested).
Trent W. Buck <[email protected]>**20081227141921] 
[Rewrite primitive matcher examples.
Trent W. Buck <[email protected]>**20081227141845] 
[Rewrite "darcs help --match" output.
Trent W. Buck <[email protected]>**20081227141819
 Add an introductory paragraph, and put all the examples into a single
 code block, since one-line paragraphs are kind hard to read.
] 
[Delete superfluous "Introduction" headings.
Trent W. Buck <[email protected]>**20081227034129
 I don't think it's useful to grant a subsection heading to the single
 introductory paragraph of a section.
] 
[Refactor error text for readability.
Trent W. Buck <[email protected]>**20081109144007] 
[Tweak user manual's title page.
Trent W. Buck <[email protected]>**20081227011031
 It annoyed me that the user manual was just called "Darcs", not "Darcs
 User Manual".
] 
[Improve readability of bug reporting.
Trent W. Buck <[email protected]>**20081226104243
 Moving "at <location>" to the first line gives the descriptive string
 a line all to itself.  For example, darcs show bug:
 
     darcs: bug at src/Darcs/Commands/ShowBug.lhs:57 compiled Nov  4 2008 12:05:43
     This is actually a fake bug in darcs.
] 
[Haddockize developer comment.
Trent W. Buck <[email protected]>**20081214041902] 
[Darcs.ColorPrinter: factor out getPolicy call
[email protected]**20081222180227
 Ignore-this: aee5b5415ee8bbfe1dac06e240b90080
 Less redundancy. 'getPolicy' is being called with the same args, and it's
 not like the environmental variables are going to change in between each
 call.
] 
[Make it possible to run just specific tests from cabal commandline.
Petr Rockai <[email protected]>**20081223083742
 
 All of `cabal test repair-corrupt bugs/newlines bugs/issue27.sh` should work as
 expected. The implementation is not very efficient, but seems to work fine.
] 
[Neatify "cabal test" option munging in Setup.lhs.
Petr Rockai <[email protected]>**20081223080811] 
[Sort the list of tests that are run by cabal.
Petr Rockai <[email protected]>**20081223073642] 
[Remove now-unused replacePristine.
Petr Rockai <[email protected]>**20081210065138] 
[resolve issue948: rewrite darcsman.
Trent W. Buck <[email protected]>**20081221081934
 
 Significant changes are:
 
  - Avoid duplicating groups from TheCommands.
  - Due to growing command_helps, list commands in SYNOPSIS.
  - Use subsections (.SS) for groups.
  - Include (with fancy markup!) command arguments.
  - Include darcs help --match.
  - Copy-and-paste description from darcs.cabal.
  - Remove AUTHORS section as suggested by man-pages(7).
  - Declare my copyright.
 
] 
[Tweak punctuation in "darcs help --match".
Trent W. Buck <[email protected]>**20081221080949
 
 Manpages treat apostrophes in the first line specially.  Use `TeX
 style' quotes instead, so this string can be included in the manpage.
 
 Also omit mention of &&, || and ! until I find time to clarify that
 they are aliases for the human-readable and, or and not.
] 
[TAG 2.2.0
Petr Rockai <[email protected]>**20090115150916] 
Patch bundle hash:
0722965db63b24776d66c99395fd62ac822b92a3
_______________________________________________
darcs-users mailing list
[email protected]
http://lists.osuosl.org/mailman/listinfo/darcs-users

Reply via email to