Hello. I have completed the review. It took much longer than expected, sorry.
All patches look good to me. I have no comments except for coding style: - Function names in Darcs.Hash module could be more consistent. There are hexValue/hexValueB and asHash/bsAsHash. IMHO it is better to use a similar suffix/prefix for all BS functions. - There are many trailing whitespaces, inconsistent spaces near opening/closing brackets, e.g.: > +import qualified Data.ByteString.Char8 as BC ( pack) And bad indentation, like: > +module Darcs.Hash (Hash(..) > + ,hexValue, hexValueB Other than this the patches are fine. Regards, Dmitry On Tue, Jan 20, 2009 at 12:36 AM, <[email protected]> wrote: > Mon Jan 19 19:06:21 CET 2009 Florent Becker <[email protected]> > * Make a proper type for hashes > This type is not being used everywhere (hence the unsafeAsHash function > in Darcs.Hash), but it should be soon. > > Mon Jan 19 22:12:09 CET 2009 [email protected] > * Use Darcs.Hash in hopefully > > Mon Jan 19 22:33:41 CET 2009 [email protected] > * Remove unsafe functions from Darcs.Hash > > Finishing the job was not as hard as i thought, here is a complete version > please review this one first > > Florent > > > _______________________________________________ > darcs-users mailing list > [email protected] > http://lists.osuosl.org/mailman/listinfo/darcs-users > > _______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
