Dmitry Kurochkin <[email protected]> writes: > Hello. > > I have completed the review. It took much longer than expected, sorry. > > All patches look good to me. I have no comments except for coding style: > > - Function names in Darcs.Hash module could be more consistent. There > are hexValue/hexValueB and asHash/bsAsHash. IMHO it is better to use a > similar suffix/prefix for all BS functions. > - There are many trailing whitespaces, inconsistent spaces near > opening/closing brackets, e.g.: > >> +import qualified Data.ByteString.Char8 as BC ( pack) > > And bad indentation, like: > >> +module Darcs.Hash (Hash(..) >> + ,hexValue, hexValueB > > > Other than this the patches are fine. > I'll send a clean version soon(-ish).
Florent _______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
