Fast patching!

Do you want to amend this?  I'll just apply it tomorrow if I don't hear back.

On Thu, Apr 09, 2009 at 15:12:58 +1000, Trent W.Buck wrote:
> Thu Apr  9 14:42:54 EST 2009  Trent W. Buck <[email protected]>
>   * Resolve issue1423: complain about empty add/remove.

Resolve issue1423: complain about empty add/remove.
---------------------------------------------------
> Trent W. Buck <[email protected]>**20090409044254
>  Ignore-this: 6367d74fc30a54b1011fbd98a01c92e8
> ] hunk ./src/Darcs/Commands/Add.lhs 102
>  add_cmd opts args = withRepoLock opts $- \repository ->
>   do cur <- slurp_pending repository
>      origfiles <- map toFilePath `fmap` fixSubPaths opts args
> +    if null origfiles
> +       then putStrLn "Nothing specified, nothing added." >>
> +            putStrLn "Maybe you wanted to say `darcs add --recursive .'?"
> +            -- FIXME: should this also exitWith ExitFailure ?

I guess not, since it's not really an error, just a case where the user did
something "correct", but probably unintentional.  The git folks seem to agree

$ git add; echo $?
Nothing specified, nothing added.
Maybe you wanted to say 'git add .'?
0

> +       else return ()
>      parlist <- get_parents cur origfiles
>      flist' <- if Recursive `elem` opts
>                then expand_dirs origfiles
> hunk ./src/Darcs/Commands/Remove.lhs 76
>  remove_cmd opts relargs =
>      withRepoLock opts $- \repository -> do
>      args <- fixSubPaths opts relargs
> +    if null args
> +       then putStrLn "Nothing specified, nothing removed."
> +            -- FIXME: should this also exitWith ExitFailure ?
> +       else return ()
>      p <- make_remove_patch repository args
>      add_to_pending repository p

-- 
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
PGP Key ID: 08AC04F9

Attachment: pgp9N784qivVR.pgp
Description: PGP signature

_______________________________________________
darcs-users mailing list
[email protected]
http://lists.osuosl.org/mailman/listinfo/darcs-users

Reply via email to