On Fri, Apr 10, 2009 at 13:21:32 +1000, Trent W.Buck wrote: > I just removed the --FIXME? comments. I don't feel strongly about it > one way or the other, and following git's precedent requires less code > and doesn't add an exit point to a procedure (multiple exit points are > yukky).
Applied, thanks! More comments below. Resolve issue1423: complain about empty add/remove. --------------------------------------------------- > Trent W. Buck <[email protected]>**20090410031243 > Ignore-this: 33f0cf72dc6d31e48d6fdda6b1f0883c > ] hunk ./src/Darcs/Commands/Add.lhs 102 > add_cmd opts args = withRepoLock opts $- \repository -> > do cur <- slurp_pending repository > origfiles <- map toFilePath `fmap` fixSubPaths opts args > + if null origfiles > + then putStrLn "Nothing specified, nothing added." >> > + putStrLn "Maybe you wanted to say `darcs add --recursive .'?" > + else return () Note that Control.Monad.when could be helpful here. Another thing which may creep up is this potentially being another manifestation of http://bugs.darcs.net/issue1397 -- Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow> PGP Key ID: 08AC04F9
pgpJFj4SUYQGz.pgp
Description: PGP signature
_______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
