Hello Dimitry,

Dmitry Kurochkin wrote:
Attached are few more patches to improve darcs changes.

I'm also working on the changes command at the moment
(using the filecache), so I'll have to manually merge
these patches anyways. Why not look at them now and
give some comments ;).

> * Do not filter patches in view_changes.

Looks OK, but I did not look at the old code in SelectChanges.hs.

> * Do not count patch number in view_changes unless requested.
> * Resolve issue1430: lazy pattern matching in (-:-) from Changes
>   command module.
>
>  Prevents darcs from computing full patch list for interactive changes.

These also look fine.

> * Make 'darcs changes --summary --only-to-files' print renames.
> * Add newline after description and indent changes when
>   --only-to-files used.
> * Fix 'changes --only-to-files' to work with renames.

Also looks nice, a comment documenting the returned value
by filter_patches_by_names and/or get_changes_info would
probably be useful.

Best,
  Benedikt

_______________________________________________
darcs-users mailing list
[email protected]
http://lists.osuosl.org/mailman/listinfo/darcs-users

Reply via email to