On Wed, Apr 22, 2009 at 10:59 PM, Eric Kow <[email protected]> wrote:
> On Wed, Apr 22, 2009 at 22:39:11 +0400, Dmitry Kurochkin wrote:
>> >> >> * Fix 'changes --only-to-files' to work with renames.
>> >> >
>> >> > Also looks nice, a comment documenting the returned value
>> >> > by filter_patches_by_names and/or get_changes_info would
>> >> > probably be useful.
>> >>
>> >> This one conflicts with max-count patches and haddock. So I would
>> >> amend it and add comments.
>> >
>> > ...and will wait for Dmitry's amended version of these
>>
>> Here it is.
>
> OK, I'll apply this in my local repo on the assumption that it's the
> same patch as what Benedikt reviewed modulo tweaks.  It will go out on
> the next round unless somebody shouts.

Good. I have just sent another patch (that depends on this patch) for
changes command that fixes --max-count.

>
> (I confess I never really quite got --only-to-files: could you explain
> it?  I'm thinking it just hides the changes to files other than the
> ones you explicitly requested in the darcs changes args list)

--only-to-files affects --summary mode:

> ./dist/build/darcs/darcs changes --summary --max-count 1 aclocal.m4
Changes to aclocal.m4:

Fri Oct 10 17:47:27 MSD 2008  David Roundy <[email protected]>
  * eliminate autogeneration of Workaround.hs.

    M ./GNUmakefile -2 +2
    M ./aclocal.m4 -230
    M ./configure.ac -23 +8
    M ./src/Autoconf.lhs.in -1 +5
    M ./src/Darcs/Lock.lhs -2 +2
    A ./src/Workaround.hs
    M ./src/win32/System/Posix/Files.hsc +9

And with --only-to-files:

> ./dist/build/darcs/darcs changes --summary --max-count 1 --only-to-files 
> aclocal.m4
Changes to aclocal.m4:

Fri Oct 10 17:47:27 MSD 2008  David Roundy <[email protected]>
  * eliminate autogeneration of Workaround.hs.

    M ./aclocal.m4 -230

BTW --only-to-files does not work with --xml-output. But I am not sure
it worth fixing.

Regards,
  Dmitry

>
> --
> Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
> PGP Key ID: 08AC04F9
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (GNU/Linux)
>
> iEYEARECAAYFAknvaQgACgkQBUrOwgisBPm60gCfeM8wCs2EQp8Xu6w827byXsO8
> J58AoNEZgGRODU6b5eLcxKNH9JzioYCo
> =BPaG
> -----END PGP SIGNATURE-----
>
>
_______________________________________________
darcs-users mailing list
[email protected]
http://lists.osuosl.org/mailman/listinfo/darcs-users

Reply via email to