On Wed, Apr 22, 2009 at 12:26:59 -0700, Dmitry Kurochkin wrote:
> Wed Apr 22 22:23:58 MSD 2009  Dmitry Kurochkin <[email protected]>
>   * Fix 'changes --only-to-files' to work with renames.
>   
>   To make --only-to-files work with renames we need to keep filename list
>   for each patch. Right now when file changes are printed they are matched
>   against original filenames (creation time filenames). This means that if
>   a file was renamed detailed changes are not printed for patches after
>   rename.
>   
>   "darcs changes --summary --only-to-files GNUmakefile" demonstrates the
>   issue. Detailed changes are printed only for patches affecting Makefile,
>   not GNUmakefile.

Dependency (already applied in local)

> Wed Apr 22 23:26:28 MSD 2009  Dmitry Kurochkin <[email protected]>
>   * Fix changes --max-count with no files given.
>   
>   Darcs does not handle max-count when no files given:
>   
>     > darcs changes --max-count 1 --count
>     7356
>   
>   Fix empty file list case in filter_patches_by_names.

Looks good.  Applied, thanks!

Fix changes --max-count with no files given.
--------------------------------------------
> Dmitry Kurochkin <[email protected]>**20090422192628
>  Ignore-this: 2b486c6ce56267b4f3afea806e099a43
>  
>  Darcs does not handle max-count when no files given:
>  
>    > darcs changes --max-count 1 --count
>    7356
>  
>  Fix empty file list case in filter_patches_by_names.
> ] hunk ./src/Darcs/Commands/Changes.lhs 189
>                          -> ([(PatchInfoAnd p,[FilePath])], [FilePath], Doc)
>  filter_patches_by_names (Just 0) _ _ = ([], [], empty)
>  filter_patches_by_names _ _ [] = ([], [], empty)
> -filter_patches_by_names _ [] pps = (zip pps (repeat []), [], empty)
> +filter_patches_by_names maxcount [] (hp:ps) =
> +    (hp, []) -:- filter_patches_by_names (subtract 1 `fmap` maxcount) [] ps
>  filter_patches_by_names maxcount fs (hp:ps)
>      | Just p <- hopefullyM hp =
>      case look_touch fs (invert p) of

-- 
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
PGP Key ID: 08AC04F9

Attachment: signature.asc
Description: Digital signature

_______________________________________________
darcs-users mailing list
[email protected]
http://lists.osuosl.org/mailman/listinfo/darcs-users

Reply via email to