On Mon, Jun 08, 2009 at 08:08:25 -0700, Jason Dagit wrote: > > The only place where dirlen is Nothing is when peekItem is called from > > createItem. In this case, iName is never used, so the code is safe. Both > > createItem and peekItem are supposed to be private in the Index module. > > (I'll > > add a remark that they are unsafe and I'll add explicit export list to the > > module). > > My recommendation is to make that field hold a Maybe instead of the raw > value.
Alternatively, we could have a version used by createItem without the dirlen field and a general version which takes a mandatory field. I don't know if this would lead to something ugly though. -- Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow> PGP Key ID: 08AC04F9
signature.asc
Description: Digital signature
_______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
