Hi, "Sittampalam, Ganesh" <[email protected]> writes: > Just a couple of comments about this patch set: > >> Sat Oct 24 15:18:25 CEST 2009 Petr Rockai <[email protected]> >> * Fix replacePristine implementation on hashed repositories. > > This patch seems to contain a conflictor. I'm happy to apply it if you > know about it and aren't easily able to avoid it, but just wanted to > check. I have probably noticed that but didn't give it much attention. It probably exists because I recorded the patch without having enough of mainline at hand. I'm not even sure which patch resolves the conflict. Hmm. It doesn't seem I could easily amend that either, as there are some dependencies. Unless you think it's important, I'd rather avoid tinkering with it. :)
>> Sat Oct 24 15:19:45 CEST 2009 Petr Rockai <[email protected]> >> * Leverage replacePristine in optimize --pristine implementation. > > The previous code called cleanRepository outside the case branch, but > the new code only does so inside. Why is that? There could be garbage in > either case, couldn't there? Could, but the primary reason for cleanRepository there was that the actual operation produces a vast amount of garbage that ought to be collected. cleanRepository is potentially time-consuming operation (I actually had to fix its time complexity to make it usable) and should normally have little effect, since garbage collection happens from time to time anyway. Yours, Petr. _______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
