On Nov 16, 2009, at 17:57, [email protected] (Trent W. Buck) wrote:

Ganesh Sittampalam <[email protected]> writes:

Generally when reviewing patches, I read them directly, perhaps have a look at the source they apply to, and then decide that they're fine so
long as the tests pass. Actually keeping track of them between that
point and running the tests and pushing is a bit of a pain, and
there's a cognitive shift that feels quite disruptive.

Let me turn this around: how hard would it be to automate this, so that
patches that don't apply cleanly are automatically set to needs-amend?

Is it as simple as "apply --dry-run $attachment --repodir ..." within
the procmail script?


Having this twice could be potentailly useful. In a very "what if" kind of way...what if the patch tracker applied the patch to a special one-off temp repo and then linked the buildbot output/status to the patch's ticket in the tracker.

The idea is that submitters and reviewers would get early notifications of bad patch bundles.

I suppose there are security issues to consider.

Jason _______________________________________________
darcs-users mailing list
[email protected]
http://lists.osuosl.org/mailman/listinfo/darcs-users

Reply via email to